[Asterisk-code-review] app queue: Revert broken queue channel reference patch (asterisk[16])

[lvl]

lvl has posted comments on this change. ( https://gerrit.asterisk.org/10523 )

Change subject: app_queue: Revert broken queue channel reference patch
......................................................................


Patch Set 5:

Good catch, it was indeed possible to avoid a few of the NULL checks by using queue_data->caller_uniqueid instead.

queue_publish_multi_channel_snapshot_blob indeed already had a graceful NULL check for agent_snapshot, which simply skips adding the "agent" property to the message. So I decided to do the same for "caller", but added a LOG_WARNING message just to be on the cautious side.

I tested this scenario and didn't see any side effects, but I'd be happy to change it to a "return" at your instruction.


-- 
To view, visit https://gerrit.asterisk.org/10523
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I37334ea184ebb56e54471496b82937d4927815a0
Gerrit-Change-Number: 10523
Gerrit-PatchSet: 5
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: lvl <digium at lvlconsultancy.nl>
Gerrit-Comment-Date: Wed, 21 Nov 2018 18:16:28 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181121/6390ecbb/attachment.html>