[Asterisk-code-review] pjproject-bundled: Use AST DEVMODE for conditional compilation. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10655 )

Change subject: pjproject-bundled: Use AST_DEVMODE for conditional compilation.
......................................................................


Patch Set 3:

> Hi Corey, I am going strictly by these lines we had at
 > third-party/pjproject/Makefile.rules had before your review:
 > 
 > ifeq ($(findstring TEST_FRAMEWORK,$(MENUSELECT_CFLAGS)),)
 > PJPROJECT_CONFIG_OPTS += --disable-resample --disable-g711-codec
 > endif
 > 
 > They are saying: if TEST_FRAMEWORK is a flag then disable g711 and
 > resample. I believe saying that we previously disabled those if
 > TEST_FRAMEWORK was on is accurate.

That conditional says if TEST_FRAMEWORK is not found in MENUSELECT_CFLAGS then disable those codecs.


-- 
To view, visit https://gerrit.asterisk.org/10655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8a3613cdb711fa7e7d217c5a775a575907ae22
Gerrit-Change-Number: 10655
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Comment-Date: Fri, 16 Nov 2018 18:34:46 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181116/c65b657a/attachment.html>