<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Hi Corey, I am going strictly by these lines we had at<br>third-party/pjproject/Makefile.rules had before your review:</p><p style="white-space: pre-wrap; word-wrap: break-word;">ifeq ($(findstring TEST_FRAMEWORK,$(MENUSELECT_CFLAGS)),)<br>PJPROJECT_CONFIG_OPTS += --disable-resample --disable-g711-codec<br>endif</p><p style="white-space: pre-wrap; word-wrap: break-word;">They are saying: if TEST_FRAMEWORK is a flag then disable g711 and<br>resample. I believe saying that we previously disabled those if<br>TEST_FRAMEWORK was on is accurate.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">That conditional says if TEST_FRAMEWORK is not found in MENUSELECT_CFLAGS then disable those codecs.</p><p><a href="https://gerrit.asterisk.org/10655">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10655">change 10655</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10655"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iee8a3613cdb711fa7e7d217c5a775a575907ae22 </div>
<div style="display:none"> Gerrit-Change-Number: 10655 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Chris Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 16 Nov 2018 18:34:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-HasLabels: No </div>