[Asterisk-code-review] res pjsip: Patch for res pjsip * module load/reload crash (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10617 )

Change subject: res_pjsip: Patch for res_pjsip_* module load/reload crash
......................................................................


Patch Set 3:

Ah, I've got it.

Here's my understood scenario.

1. If the session has created once, it will increases the reference of all the registered sip-supplement modules. 
Because it well be added to session's supplement callback.

2. The module's reference count will be decreased when the session has gone.
Because it will be fired when the SIP messages are coming/going.

If I'm correct, I'm worry about below things.

- This will make it's not possible to unload the module if there's any sessions are exist.
- This will make extra-ordinary counts of references. If there's 1000 sessions are, the reference count would be 1000.

Am I right?


-- 
To view, visit https://gerrit.asterisk.org/10617
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b82be3a75d702cf1933d8d1417f44aa10ad1029
Gerrit-Change-Number: 10617
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 12 Nov 2018 12:45:37 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181112/41856f64/attachment.html>