[Asterisk-code-review] res pjsip: Patch for res pjsip * module load/reload crash (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/10617 )

Change subject: res_pjsip: Patch for res_pjsip_* module load/reload crash
......................................................................


Patch Set 3:

The ast_module_ref and ast_module_unref functions increase and decrease the reference count of a module, ensuring it can't be unloaded when in use. When a session module is actually in use by a session the ast_module_ref function should be called so it can't be unloaded. When it is no longer in use then ast_module_unref should be called. That is conceptually what should happen to resolve this problem. Allowing a module to be unloaded while in use is not something I think should be done, due to the undefined behavior I mentioned.


-- 
To view, visit https://gerrit.asterisk.org/10617
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b82be3a75d702cf1933d8d1417f44aa10ad1029
Gerrit-Change-Number: 10617
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 12 Nov 2018 12:18:28 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181112/bbc65e21/attachment-0001.html>