[Asterisk-code-review] bridge native rtp.c: Fail native bridge if no framing match.... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10495 )

Change subject: bridge_native_rtp.c: Fail native bridge if no framing match. Review update
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

Other than a couple minor nits, it looks good to me.

https://gerrit.asterisk.org/#/c/10495/4/bridges/bridge_native_rtp.c
File bridges/bridge_native_rtp.c:

https://gerrit.asterisk.org/#/c/10495/4/bridges/bridge_native_rtp.c@713
PS4, Line 713: 			/* ptimes are asymetric on the two call legs so we can't use the native bridge */
asymetric -> asymmetric


https://gerrit.asterisk.org/#/c/10495/4/bridges/bridge_native_rtp.c@714
PS4, Line 714: 			ast_debug(1, "Asymetric ptimes on the two call legs (%u != %u). Cannot native bridge in RTP\n",framing_inst0,framing_inst1);
asymetric -> asymmetric

Spaces after commas and because the line is long, wrap it:

 ast_debug(1, "...",
     framing_inst0, framing_inst1);

(the continuation line should have 1 more tab than the line it is continuing)



-- 
To view, visit https://gerrit.asterisk.org/10495
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic64b8fc6a140a93fbdb2f97550a40d0ff334e607
Gerrit-Change-Number: 10495
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Cripps <rcripps at voxbone.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Robert Cripps <rcripps at voxbone.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 08 Nov 2018 14:08:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181108/e9cba974/attachment.html>