<p style="white-space: pre-wrap; word-wrap: break-word;">Other than a couple minor nits, it looks good to me.</p><p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10495">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10495/4/bridges/bridge_native_rtp.c">File bridges/bridge_native_rtp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10495/4/bridges/bridge_native_rtp.c@713">Patch Set #4, Line 713:</a> <code style="font-family:monospace,monospace"> /* ptimes are asymetric on the two call legs so we can't use the native bridge */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">asymetric -> asymmetric</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10495/4/bridges/bridge_native_rtp.c@714">Patch Set #4, Line 714:</a> <code style="font-family:monospace,monospace"> ast_debug(1, "Asymetric ptimes on the two call legs (%u != %u). Cannot native bridge in RTP\n",framing_inst0,framing_inst1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">asymetric -> asymmetric</p><p style="white-space: pre-wrap; word-wrap: break-word;">Spaces after commas and because the line is long, wrap it:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ast_debug(1, "...",<br> framing_inst0, framing_inst1);</pre><p style="white-space: pre-wrap; word-wrap: break-word;">(the continuation line should have 1 more tab than the line it is continuing)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10495">change 10495</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10495"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic64b8fc6a140a93fbdb2f97550a40d0ff334e607 </div>
<div style="display:none"> Gerrit-Change-Number: 10495 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Robert Cripps <rcripps@voxbone.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Robert Cripps <rcripps@voxbone.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 08 Nov 2018 14:08:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>