[Asterisk-code-review] pjsip: modify taskprocessor scheduling algorithm from round-... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10587 )

Change subject: pjsip: modify taskprocessor scheduling algorithm from round-robin to least-size
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10587/2/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/10587/2/res/res_pjsip.c@4339
PS2, Line 4339: 	for (pos = idx = 0; idx < SERIALIZER_POOL_SIZE; ++idx) {
Should initialize:
pos = 0
idx = 1

to avoid an always false comparison on the first loop because idx == pos == 0.


https://gerrit.asterisk.org/#/c/10587/2/res/res_pjsip.c@4345
PS2, Line 4345: 	return serializer_pool[pos]; 
Red blob.  i.e. trailing whitespace



-- 
To view, visit https://gerrit.asterisk.org/10587
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b8d8cc2c2490494f579374b6af0a4868e3a37cd
Gerrit-Change-Number: 10587
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 22:26:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181105/786ba6e6/attachment-0001.html>