<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10587">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10587/2/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10587/2/res/res_pjsip.c@4339">Patch Set #2, Line 4339:</a> <code style="font-family:monospace,monospace">      for (pos = idx = 0; idx < SERIALIZER_POOL_SIZE; ++idx) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should initialize:<br>pos = 0<br>idx = 1</p><p style="white-space: pre-wrap; word-wrap: break-word;">to avoid an always false comparison on the first loop because idx == pos == 0.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10587/2/res/res_pjsip.c@4345">Patch Set #2, Line 4345:</a> <code style="font-family:monospace,monospace">        return serializer_pool[pos]; </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Red blob.  i.e. trailing whitespace</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10587">change 10587</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10587"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7b8d8cc2c2490494f579374b6af0a4868e3a37cd </div>
<div style="display:none"> Gerrit-Change-Number: 10587 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 05 Nov 2018 22:26:52 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>