[Asterisk-code-review] rtp: Add support for RTP extension negotiation and abs-send-... (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8883 )

Change subject: rtp: Add support for RTP extension negotiation and abs-send-time.
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

Minor nits.  -1 so you see it.

https://gerrit.asterisk.org/#/c/8883/3/include/asterisk/rtp_engine.h
File include/asterisk/rtp_engine.h:

https://gerrit.asterisk.org/#/c/8883/3/include/asterisk/rtp_engine.h@741
PS3, Line 741: 	/* The extension is not negotiated and is not flowing */
             : 	AST_RTP_EXTENSION_DIRECTION_NONE,
             : 	/* Send and receive */
Still missing ! to start doxygen comment.


https://gerrit.asterisk.org/#/c/8883/3/res/res_pjsip_sdp_rtp.c
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/#/c/8883/3/res/res_pjsip_sdp_rtp.c@1192
PS3, Line 1192: 		snprintf(extmap_value, sizeof(extmap_value), "%d%s %s", idx, direction_str, ast_rtp_instance_extmap_get_uri(session_media->rtp, idx));
Should wrap this long line at 90.


https://gerrit.asterisk.org/#/c/8883/3/res/res_pjsip_sdp_rtp.c@1247
PS3, Line 1247: 		attributes = strchr(uri, ' ');
Should use strchrnul() instead so attributes isn't NULL when passed to ast_rtp_instance_extmap_negotiate().  Though since the function doesn't use the attributes parameter it doesn't really matter and the function could document that the parameter could be NULL if there are no attributes.


https://gerrit.asterisk.org/#/c/8883/3/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/8883/3/res/res_rtp_asterisk.c@4444
PS3, Line 4444: 			unsigned int now_msw, now_lsw;
One declaration per line.



-- 
To view, visit https://gerrit.asterisk.org/8883
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I508deac557867b1e27fc7339be890c8018171588
Gerrit-Change-Number: 8883
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 18 May 2018 16:09:19 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180518/dec97aca/attachment.html>