<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8883">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Minor nits.  -1 so you see it.</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8883/3/include/asterisk/rtp_engine.h">File include/asterisk/rtp_engine.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8883/3/include/asterisk/rtp_engine.h@741">Patch Set #3, Line 741:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">      /* The extension is not negotiated and is not flowing */<br>      AST_RTP_EXTENSION_DIRECTION_NONE,<br>     /* Send and receive */<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Still missing ! to start doxygen comment.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8883/3/res/res_pjsip_sdp_rtp.c">File res/res_pjsip_sdp_rtp.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8883/3/res/res_pjsip_sdp_rtp.c@1192">Patch Set #3, Line 1192:</a> <code style="font-family:monospace,monospace">           snprintf(extmap_value, sizeof(extmap_value), "%d%s %s", idx, direction_str, ast_rtp_instance_extmap_get_uri(session_media->rtp, idx));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should wrap this long line at 90.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8883/3/res/res_pjsip_sdp_rtp.c@1247">Patch Set #3, Line 1247:</a> <code style="font-family:monospace,monospace">               attributes = strchr(uri, ' ');</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should use strchrnul() instead so attributes isn't NULL when passed to ast_rtp_instance_extmap_negotiate().  Though since the function doesn't use the attributes parameter it doesn't really matter and the function could document that the parameter could be NULL if there are no attributes.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8883/3/res/res_rtp_asterisk.c">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8883/3/res/res_rtp_asterisk.c@4444">Patch Set #3, Line 4444:</a> <code style="font-family:monospace,monospace">                      unsigned int now_msw, now_lsw;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">One declaration per line.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8883">change 8883</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8883"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I508deac557867b1e27fc7339be890c8018171588 </div>
<div style="display:none"> Gerrit-Change-Number: 8883 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 18 May 2018 16:09:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>