[Asterisk-code-review] Fix GCC 8 build issues. (asterisk[15])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8935 )

Change subject: Fix GCC 8 build issues.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/8935/1/apps/app_minivm.c
File apps/app_minivm.c:

https://gerrit.asterisk.org/#/c/8935/1/apps/app_minivm.c@a2789
PS1, Line 2789: 
> Since len doesn't include null termination, is this safe here?
Hmm so I'm actually changing the behavior with my patch since len was always 1, the current patch sets tmpwrite[1] = '\0' where that previously wasn't done.  Maybe the correct replacement line should should be:
tmpwrite[0] = '\n';

The memmove before actually copies stuff into memory starting at tmpwrite[1] so I'm thinking that the lack of null termination at tmpwrite[1] is intention?



-- 
To view, visit https://gerrit.asterisk.org/8935
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I724f146cbddba8b86619d4c4a9931ee877995c84
Gerrit-Change-Number: 8935
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Mon, 07 May 2018 19:25:46 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180507/eb471c82/attachment.html>