<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8935">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8935/1/apps/app_minivm.c">File apps/app_minivm.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8935/1/apps/app_minivm.c@a2789">Patch Set #1, Line 2789:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Since len doesn't include null termination, is this safe here?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Hmm so I'm actually changing the behavior with my patch since len was always 1, the current patch sets tmpwrite[1] = '\0' where that previously wasn't done.  Maybe the correct replacement line should should be:<br>tmpwrite[0] = '\n';</p><p style="white-space: pre-wrap; word-wrap: break-word;">The memmove before actually copies stuff into memory starting at tmpwrite[1] so I'm thinking that the lack of null termination at tmpwrite[1] is intention?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8935">change 8935</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8935"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I724f146cbddba8b86619d4c4a9931ee877995c84 </div>
<div style="display:none"> Gerrit-Change-Number: 8935 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 07 May 2018 19:25:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>