[Asterisk-code-review] test data buffer.c: Add unit tests for data buffer API. (asterisk[15])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8605 )

Change subject: test_data_buffer.c: Add unit tests for data buffer API.
......................................................................


Patch Set 3: Code-Review-1

(7 comments)

https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c
File tests/test_data_buffer.c:

https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@47
PS3, Line 47: 	struct ast_data_buffer *buffer;
If you use RAII_VAR here, you can eliminate most of the duplicate checking code below by using ast_test_validate().


https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@91
PS3, Line 91: 	struct ast_data_buffer *buffer;
same


https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@234
PS3, Line 234: 	struct ast_data_buffer *buffer;
same


https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@268
PS3, Line 268: 	
red blob


https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@282
PS3, Line 282: 	
blob


https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@295
PS3, Line 295: 	
blob


https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@308
PS3, Line 308: 	struct ast_data_buffer *buffer;
same RAII_VAR



-- 
To view, visit https://gerrit.asterisk.org/8605
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5b599aa15a5e61d0ec080f97cd0c57bd07e6f8f
Gerrit-Change-Number: 8605
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 20 Mar 2018 11:59:57 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180320/94045a0d/attachment.html>