<p>George Joseph <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8605">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(7 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c">File tests/test_data_buffer.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@47">Patch Set #3, Line 47:</a> <code style="font-family:monospace,monospace">       struct ast_data_buffer *buffer;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If you use RAII_VAR here, you can eliminate most of the duplicate checking code below by using ast_test_validate().</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@91">Patch Set #3, Line 91:</a> <code style="font-family:monospace,monospace">    struct ast_data_buffer *buffer;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@234">Patch Set #3, Line 234:</a> <code style="font-family:monospace,monospace"> struct ast_data_buffer *buffer;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@268">Patch Set #3, Line 268:</a> <code style="font-family:monospace,monospace"> </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red blob</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@282">Patch Set #3, Line 282:</a> <code style="font-family:monospace,monospace">    </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">blob</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@295">Patch Set #3, Line 295:</a> <code style="font-family:monospace,monospace">        </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">blob</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8605/3/tests/test_data_buffer.c@308">Patch Set #3, Line 308:</a> <code style="font-family:monospace,monospace">        struct ast_data_buffer *buffer;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">same RAII_VAR</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8605">change 8605</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8605"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id5b599aa15a5e61d0ec080f97cd0c57bd07e6f8f </div>
<div style="display:none"> Gerrit-Change-Number: 8605 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 20 Mar 2018 11:59:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>