[Asterisk-code-review] Add data buffer API to store packets. (asterisk[15])

Joshua Colp asteriskteam at digium.com
Mon Mar 19 11:59:34 CDT 2018


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8604 )

Change subject: Add data buffer API to store packets.
......................................................................


Patch Set 1:

Speaking for me I went back and forth between using a vector and linked list, but wanted to keep it simple until we actually experienced any performance issues. To really use a vector efficiently you'd have to translate from the provided position into an index in the vector, which is certainly possible but would require a lot of thought and testing.


-- 
To view, visit https://gerrit.asterisk.org/8604
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff13c5d4795d52356959fe2a57360cd57dfade07
Gerrit-Change-Number: 8604
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 19 Mar 2018 16:59:34 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180319/16f75cde/attachment.html>


More information about the asterisk-code-review mailing list