[Asterisk-code-review] Add data buffer API to store packets. (asterisk[15])

George Joseph asteriskteam at digium.com
Mon Mar 19 11:50:27 CDT 2018


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/8604 )

Change subject: Add data buffer API to store packets.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Did Josh give you any direction as to what the usage pattern might be?  If there are going to be lots of operations by index I'm wondering if a vector would be more appropriate than a linked list for the backing store.

https://gerrit.asterisk.org/#/c/8604/1/include/asterisk/data_buffer.h
File include/asterisk/data_buffer.h:

https://gerrit.asterisk.org/#/c/8604/1/include/asterisk/data_buffer.h@33
PS1, Line 33: 
You should copy the blurb in the wiki that describes the  purpose of the api and how to use it.  Otherwise you have to look at the commit message to find the background.



-- 
To view, visit https://gerrit.asterisk.org/8604
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff13c5d4795d52356959fe2a57360cd57dfade07
Gerrit-Change-Number: 8604
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Mon, 19 Mar 2018 16:50:27 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180319/f17dd507/attachment-0001.html>


More information about the asterisk-code-review mailing list