[Asterisk-code-review] loader: Convert reload classes to built-in modules. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Tue Mar 13 12:46:40 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8390 )

Change subject: loader: Convert reload_classes to built-in modules.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/8390/4/res/res_config_sqlite.c
File res/res_config_sqlite.c:

https://gerrit.asterisk.org/#/c/8390/4/res/res_config_sqlite.c@1781
PS4, Line 1781: 	.optional_modules = "cdr",
> This module must ignore cdr as a startup dependency since this is a realtim
I'll add a comment / remove the "cdr" dependency.  At this point I'm going to hold back on this update.  I'm unsure if the conflict is real or just gerrit being gerrit but I'd prefer the MALLOC_DEBUG patch be merged first so the conflict can be dealt with from this commit.



-- 
To view, visit https://gerrit.asterisk.org/8390
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I371a9a45064f20026c492623ea8062d02a1ab97f
Gerrit-Change-Number: 8390
Gerrit-PatchSet: 4
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 13 Mar 2018 17:46:40 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180313/c1e1e9b6/attachment.html>


More information about the asterisk-code-review mailing list