[Asterisk-code-review] loader: Convert reload classes to built-in modules. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8390 )

Change subject: loader: Convert reload_classes to built-in modules.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

This module should be good to go after fixing the one finding.

https://gerrit.asterisk.org/#/c/8390/4/res/res_config_sqlite.c
File res/res_config_sqlite.c:

https://gerrit.asterisk.org/#/c/8390/4/res/res_config_sqlite.c@1781
PS4, Line 1781: 	.optional_modules = "cdr",
This module must ignore cdr as a startup dependency since this is a realtime config driver.  Otherwise it forces the built-in cdr module to start too early and not be able to use realtime.

In this case it is ok to call ast_cdr_register() before the built-in cdr initializes.  You could add a comment to this effect if you want.



-- 
To view, visit https://gerrit.asterisk.org/8390
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I371a9a45064f20026c492623ea8062d02a1ab97f
Gerrit-Change-Number: 8390
Gerrit-PatchSet: 4
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 12 Mar 2018 19:27:12 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180312/56059f57/attachment.html>