[Asterisk-code-review] channels/pjsip/ami/pjsip notify/channel: 3PCC patch for AMI ... (testsuite[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8515 )

Change subject: channels/pjsip/ami/pjsip_notify/channel: 3PCC patch for AMI "PJSIPNotify"
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/sipp/callee.xml
File tests/channels/pjsip/ami/pjsip_notify/channel/sipp/callee.xml:

https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/sipp/callee.xml@108
PS1, Line 108:       [last_To:];tag=[pid]SIPpTag[call_number]
Adding the tag here is not needed.  You wind up with two tags on the header.

You have to do it on the initial INVITE because asterisk doesn't know what the To tag will be.  Asterisk knows the To tag for the BYE so it is in the last_To from the BYE.


https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/test-config.yaml
File tests/channels/pjsip/ami/pjsip_notify/channel/test-config.yaml:

https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/test-config.yaml@41
PS1, Line 41:     minversion: [ '15.4.0' ]
If the feature is intended to also go into the 13 branch then 13.21.0 would need to be added to the list:
[ '13.21.0', '15.4.0' ]


https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/test-config.yaml@45
PS1, Line 45:         - asterisk : 'chan_pjsip'
Need to add dependency:
  - asterisk: 'app_dial'



-- 
To view, visit https://gerrit.asterisk.org/8515
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2047ca031c3c00b17b2ea06f1008fb17f84846d0
Gerrit-Change-Number: 8515
Gerrit-PatchSet: 1
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 12 Mar 2018 20:41:23 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180312/773978d0/attachment.html>