<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8515">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/sipp/callee.xml">File tests/channels/pjsip/ami/pjsip_notify/channel/sipp/callee.xml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/sipp/callee.xml@108">Patch Set #1, Line 108:</a> <code style="font-family:monospace,monospace">      [last_To:];tag=[pid]SIPpTag[call_number]</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Adding the tag here is not needed.  You wind up with two tags on the header.</p><p style="white-space: pre-wrap; word-wrap: break-word;">You have to do it on the initial INVITE because asterisk doesn't know what the To tag will be.  Asterisk knows the To tag for the BYE so it is in the last_To from the BYE.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/test-config.yaml">File tests/channels/pjsip/ami/pjsip_notify/channel/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/test-config.yaml@41">Patch Set #1, Line 41:</a> <code style="font-family:monospace,monospace">    minversion: [ '15.4.0' ]</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If the feature is intended to also go into the 13 branch then 13.21.0 would need to be added to the list:<br>[ '13.21.0', '15.4.0' ]</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8515/1/tests/channels/pjsip/ami/pjsip_notify/channel/test-config.yaml@45">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace">        - asterisk : 'chan_pjsip'</code></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Need to add dependency:<br>  - asterisk: 'app_dial'</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8515">change 8515</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8515"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2047ca031c3c00b17b2ea06f1008fb17f84846d0 </div>
<div style="display:none"> Gerrit-Change-Number: 8515 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lvl <digium@lvlconsultancy.nl> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 12 Mar 2018 20:41:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>