[Asterisk-code-review] Replace direct checks of option debug with DEBUG ATLEAST macro. (asterisk[13])

Corey Farrell asteriskteam at digium.com
Wed Mar 7 16:02:35 CST 2018


Hello Richard Mudgett, Jenkins2, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8451

to look at the new patch set (#3).

Change subject: Replace direct checks of option_debug with DEBUG_ATLEAST macro.
......................................................................

Replace direct checks of option_debug with DEBUG_ATLEAST macro.

Checking option_debug directly is incorrect as it ignores file/module
specific debug settings.  This system-wide change replaces nearly all
direct checks for option_debug with the DEBUG_ATLEAST macro.

Change-Id: Ic342d4799a945dbc40ac085ac142681094a4ebf0
---
M addons/chan_ooh323.c
M apps/app_directory.c
M apps/app_minivm.c
M apps/app_voicemail.c
M cdr/cdr_pgsql.c
M cel/cel_pgsql.c
M channels/chan_dahdi.c
M channels/chan_sip.c
M main/callerid.c
M main/config.c
M main/netsock2.c
M main/pbx.c
M main/sched.c
M res/res_config_ldap.c
M res/res_config_pgsql.c
M res/res_rtp_asterisk.c
16 files changed, 88 insertions(+), 89 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/51/8451/3
-- 
To view, visit https://gerrit.asterisk.org/8451
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic342d4799a945dbc40ac085ac142681094a4ebf0
Gerrit-Change-Number: 8451
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180307/5a8b62b7/attachment.html>


More information about the asterisk-code-review mailing list