[Asterisk-code-review] Replace direct checks of option debug with DEBUG ATLEAST macro. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8451 )

Change subject: Replace direct checks of option_debug with DEBUG_ATLEAST macro.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/8451/2/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/8451/2/channels/chan_sip.c@22343
PS2, Line 22343: 	ast_log(LOG_DEBUG, "\n---------- SIP HISTORY for '%s' \n", dialog->callid);
               : 	if (dialog->subscribed) {
               : 		ast_log(LOG_DEBUG, "  * Subscription\n");
               : 	} else {
               : 		ast_log(LOG_DEBUG, "  * SIP Call\n");
               : 	}
               : 	if (dialog->history) {
               : 		AST_LIST_TRAVERSE(dialog->history, hist, list)
               : 			ast_log(LOG_DEBUG, "  %-3.3d. %s\n", ++x, hist->event);
               : 	}
               : 	if (!x) {
               : 		ast_log(LOG_DEBUG, "Call '%s' has no history\n", dialog->callid);
               : 	}
               : 	ast_log(LOG_DEBUG, "\n---------- END SIP HISTORY for '%s' \n", dialog->callid);
> So this is just an observation / no action required?
Yep.  Just an observation.



-- 
To view, visit https://gerrit.asterisk.org/8451
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic342d4799a945dbc40ac085ac142681094a4ebf0
Gerrit-Change-Number: 8451
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 21:53:06 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180307/a83915fa/attachment-0001.html>