[Asterisk-code-review] res pjsip notify.c: enable in-dialog NOTIFY (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8374 )

Change subject: res_pjsip_notify.c: enable in-dialog NOTIFY
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

Minor comments, but almost there.

https://gerrit.asterisk.org/#/c/8374/3/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/8374/3/res/res_pjsip.c@4745
PS3, Line 4745: struct pjsip_dialog *ast_sip_get_dialog_for_channel(struct ast_channel *ch) {
This function should go into res_pjsip_session, as it is for accessing information from a channel and session.


https://gerrit.asterisk.org/#/c/8374/3/res/res_pjsip_notify.c
File res/res_pjsip_notify.c:

https://gerrit.asterisk.org/#/c/8374/3/res/res_pjsip_notify.c@739
PS3, Line 739: 	// keep the channel locked so the dialog can't go away
In Asterisk we don't use this type of comment



-- 
To view, visit https://gerrit.asterisk.org/8374
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: If7f3151a6d633e414d5dc319d5efc1443c43dd29
Gerrit-Change-Number: 8374
Gerrit-PatchSet: 3
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 15:09:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180306/151d3867/attachment.html>