<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8374">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Minor comments, but almost there.</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8374/3/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/3/res/res_pjsip.c@4745">Patch Set #3, Line 4745:</a> <code style="font-family:monospace,monospace">struct pjsip_dialog *ast_sip_get_dialog_for_channel(struct ast_channel *ch) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This function should go into res_pjsip_session, as it is for accessing information from a channel and session.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8374/3/res/res_pjsip_notify.c">File res/res_pjsip_notify.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8374/3/res/res_pjsip_notify.c@739">Patch Set #3, Line 739:</a> <code style="font-family:monospace,monospace">    // keep the channel locked so the dialog can't go away</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In Asterisk we don't use this type of comment</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8374">change 8374</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8374"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If7f3151a6d633e414d5dc319d5efc1443c43dd29 </div>
<div style="display:none"> Gerrit-Change-Number: 8374 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Nathan Bruning <nathan@iperity.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Mar 2018 15:09:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>