[Asterisk-code-review] res pjsip messaging: Allow application/* for in-dialog MESS... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9292 )

Change subject: res_pjsip_messaging:  Allow application/* for in-dialog MESSAGEs
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c@91
PS2, Line 91: 	pj_str_t text = { "text", 4};
            : 	pj_str_t application = { "application", 11};
These should be made "static const".  There is no need to initialize them for every time the function is called.


https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c@94
PS2, Line 94: 	/* We'll accept any text/ content type */
* Update comment.  Is the comment even needed if the \details section is up-to-date?

* The debug message in channel.c:ast_sendtext_data(): "Channel technology does not support sending text on channel '%s'\n" is not accurate with these expanded content types.

ast_debug(1, "Channel technology does not support sending '%s' content on channel '%s'\n",
   S_OR(content_type, "text/plain"),
   ast_channel_name(chan));


https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c@100
PS2, Line 100: 		&& pj_stricmp(&rdata->msg_info.ctype->media.type, &text) == 0) {
Does this need to be updated too?  Incidentally, the only caller doesn't even look at this location for the content type.



-- 
To view, visit https://gerrit.asterisk.org/9292
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e54d8cc6158dc47eb8fdd6ba0108c6fd53f2818
Gerrit-Change-Number: 9292
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 19:00:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180626/1cf5fd2a/attachment-0001.html>