<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9292">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c">File res/res_pjsip_messaging.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c@91">Patch Set #2, Line 91:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">     pj_str_t text = { "text", 4};<br>       pj_str_t application = { "application", 11};<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These should be made "static const".  There is no need to initialize them for every time the function is called.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c@94">Patch Set #2, Line 94:</a> <code style="font-family:monospace,monospace"> /* We'll accept any text/ content type */</code></p><ul><li>Update comment.  Is the comment even needed if the \details section is up-to-date?</li></ul><ul><li>The debug message in channel.c:ast_sendtext_data(): "Channel technology does not support sending text on channel '%s'\n" is not accurate with these expanded content types.</li></ul><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ast_debug(1, "Channel technology does not support sending '%s' content on channel '%s'\n",<br>   S_OR(content_type, "text/plain"),<br>   ast_channel_name(chan));</pre></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9292/2/res/res_pjsip_messaging.c@100">Patch Set #2, Line 100:</a> <code style="font-family:monospace,monospace">           && pj_stricmp(&rdata->msg_info.ctype->media.type, &text) == 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does this need to be updated too?  Incidentally, the only caller doesn't even look at this location for the content type.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9292">change 9292</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9292"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I4e54d8cc6158dc47eb8fdd6ba0108c6fd53f2818 </div>
<div style="display:none"> Gerrit-Change-Number: 9292 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Jun 2018 19:00:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>