[Asterisk-code-review] res pjsip session: Add ability to accept multiple sdp answers (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/9200 )

Change subject: res_pjsip_session:  Add ability to accept multiple sdp answers
......................................................................


Patch Set 5: Code-Review-1

(4 comments)

According CHANGES the default value of the 'follow_early_media_forked' option is "yes" which is the current behavior.

https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip.c@1030
PS5, Line 1030: <configOption name="follow_early_media_fork" default="no">
should be default="yes"


https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/config_system.c
File res/res_pjsip/config_system.c:

https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/config_system.c@58
PS5, Line 58: onm or off
on or off


https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/config_system.c@201
PS5, Line 201: ast_sorcery_object_field_register(system_sorcery, "system", "follow_early_media_fork", "no"
default value should be "yes"


https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/pjsip_configuration.c@1857
PS5, Line 1857: 	ast_sorcery_object_field_register(sip_sorcery, "endpoint", "follow_early_media_fork", "no", OPT_BOOL_T, 1, FLDSET(struct ast_sip_endpoint, media.rtp.follow_early_media_fork));
default value should be "yes"



-- 
To view, visit https://gerrit.asterisk.org/9200
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I64d071942b79adb2f0a4e13137389b19404fe3d6
Gerrit-Change-Number: 9200
Gerrit-PatchSet: 5
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 20 Jun 2018 14:32:02 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180620/f42340d5/attachment-0001.html>