<p>Alexei Gradinari <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9200">View Change</a></p><p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">According CHANGES the default value of the 'follow_early_media_forked' option is "yes" which is the current behavior.</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip.c@1030">Patch Set #5, Line 1030:</a> <code style="font-family:monospace,monospace"><configOption name="follow_early_media_fork" default="no"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">should be default="yes"</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/config_system.c">File res/res_pjsip/config_system.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/config_system.c@58">Patch Set #5, Line 58:</a> <code style="font-family:monospace,monospace">onm or off</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">on or off</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/config_system.c@201">Patch Set #5, Line 201:</a> <code style="font-family:monospace,monospace">ast_sorcery_object_field_register(system_sorcery, "system", "follow_early_media_fork", "no"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">default value should be "yes"</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/pjsip_configuration.c">File res/res_pjsip/pjsip_configuration.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/5/res/res_pjsip/pjsip_configuration.c@1857">Patch Set #5, Line 1857:</a> <code style="font-family:monospace,monospace">  ast_sorcery_object_field_register(sip_sorcery, "endpoint", "follow_early_media_fork", "no", OPT_BOOL_T, 1, FLDSET(struct ast_sip_endpoint, media.rtp.follow_early_media_fork));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">default value should be "yes"</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9200">change 9200</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9200"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I64d071942b79adb2f0a4e13137389b19404fe3d6 </div>
<div style="display:none"> Gerrit-Change-Number: 9200 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 20 Jun 2018 14:32:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>