[Asterisk-code-review] func odbc: NODATA if SQLNumResultCols returned 0 columns on ... (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/9070 )

Change subject: func_odbc: NODATA if SQLNumResultCols returned 0 columns on readsql
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/9070/2/funcs/func_odbc.c
File funcs/func_odbc.c:

https://gerrit.asterisk.org/#/c/9070/2/funcs/func_odbc.c@1543
PS2, Line 1543: 				release_obj_or_dsn (&obj, &dsn);
> Doesn't this occur further down once the break is done?
Yes, it occurs, but it's safe, because release_obj_or_dsn do nothing if obj/dsn already released.
There are a few places where release_obj_or_dsn called and then break: 
1. if (res == SQL_NO_DATA) (line 1553)
2. on success (line 1599)

Should I rewrite all these to apply this patch?



-- 
To view, visit https://gerrit.asterisk.org/9070
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f7bdac6c405aa5bbd38932c7b831f90729ee19
Gerrit-Change-Number: 9070
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 07 Jun 2018 14:14:05 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180607/cf228d55/attachment-0001.html>