<p>Alexei Gradinari <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9070">View Change</a></p><p>Patch set 2:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9070/2/funcs/func_odbc.c">File funcs/func_odbc.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9070/2/funcs/func_odbc.c@1543">Patch Set #2, Line 1543:</a> <code style="font-family:monospace,monospace">                         release_obj_or_dsn (&obj, &dsn);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Doesn't this occur further down once the break is done?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes, it occurs, but it's safe, because release_obj_or_dsn do nothing if obj/dsn already released.<br>There are a few places where release_obj_or_dsn called and then break: <br>1. if (res == SQL_NO_DATA) (line 1553)<br>2. on success (line 1599)</p><p style="white-space: pre-wrap; word-wrap: break-word;">Should I rewrite all these to apply this patch?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9070">change 9070</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9070"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie0f7bdac6c405aa5bbd38932c7b831f90729ee19 </div>
<div style="display:none"> Gerrit-Change-Number: 9070 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 07 Jun 2018 14:14:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>