[Asterisk-code-review] app confbridge: Enable sending events to participants (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/9085 )

Change subject: app_confbridge:  Enable sending events to participants
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/9085/2/apps/app_confbridge.c
File apps/app_confbridge.c:

https://gerrit.asterisk.org/#/c/9085/2/apps/app_confbridge.c@554
PS2, Line 554: 
Add comments to here and bridge_to_json explaining why it deletes certain things.


https://gerrit.asterisk.org/#/c/9085/2/apps/app_confbridge.c@635
PS2, Line 635: 
On giving this some further thought I think a more reliable method would be to iterate the stream topology looking for streams that are recvonly or sendrecv. These would be ones sending media to Asterisk, and thus sources.


https://gerrit.asterisk.org/#/c/9085/2/apps/app_confbridge.c@662
PS2, Line 662: 	ast_json_unref(json_object);
Having the msg_name and json done above, and then ast_json_unref here can throw people off on a quick read. I think having them be set with it would be better.



-- 
To view, visit https://gerrit.asterisk.org/9085
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I26420aa9f101f0b2387dc9e2fd10733197f1318e
Gerrit-Change-Number: 9085
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 10:01:42 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180606/3800e413/attachment-0001.html>