<p>Joshua Colp <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9085">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9085/2/apps/app_confbridge.c">File apps/app_confbridge.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9085/2/apps/app_confbridge.c@554">Patch Set #2, Line 554:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add comments to here and bridge_to_json explaining why it deletes certain things.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9085/2/apps/app_confbridge.c@635">Patch Set #2, Line 635:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">On giving this some further thought I think a more reliable method would be to iterate the stream topology looking for streams that are recvonly or sendrecv. These would be ones sending media to Asterisk, and thus sources.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9085/2/apps/app_confbridge.c@662">Patch Set #2, Line 662:</a> <code style="font-family:monospace,monospace">       ast_json_unref(json_object);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Having the msg_name and json done above, and then ast_json_unref here can throw people off on a quick read. I think having them be set with it would be better.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9085">change 9085</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9085"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 15 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I26420aa9f101f0b2387dc9e2fd10733197f1318e </div>
<div style="display:none"> Gerrit-Change-Number: 9085 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 06 Jun 2018 10:01:42 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>