[Asterisk-code-review] confbridge talking list: Add test for ConfbridgeList 'Talkin... (testsuite[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9071 )

Change subject: confbridge_talking_list: Add test for ConfbridgeList 'Talking' header
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

This is a really good test.  It is a better test than I was expecting.

Just have some minor things to clean up.

https://gerrit.asterisk.org/#/c/9071/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/9071/1//COMMIT_MSG@9
PS1, Line 9: In ASTERISK-27877, the "Talking" header was added to ConfbridgeList.
Remove this sentence and add ASTERISK-27877 to its own line after this paragraph like normal commit messages.


https://gerrit.asterisk.org/#/c/9071/1//COMMIT_MSG@12
PS1, Line 12: and 'ConfbridgeTalking' events to tell when to check the change in the 'Talking'
...in the ConfbridgeList 'Talking'...


https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/confbridge_talking_list/sipp/invite.xml
File tests/apps/confbridge/confbridge_talking_list/sipp/invite.xml:

https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/confbridge_talking_list/sipp/invite.xml@77
PS1, Line 77: 
Need to add

<recv response="200" />

to complete the BYE transaction.


https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/confbridge_talking_list/test-config.yaml
File tests/apps/confbridge/confbridge_talking_list/test-config.yaml:

https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/confbridge_talking_list/test-config.yaml@85
PS1, Line 85:         - asterisk : 'chan_pjsip'
Add missing test dependency since it uses CALLERID() dialplan function:

- asterisk: 'func_callerid'


https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/tests.yaml
File tests/apps/confbridge/tests.yaml:

https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/tests.yaml@20
PS1, Line 20:     - test: 'confbridge_talking_list'
Should add this in sorted order.



-- 
To view, visit https://gerrit.asterisk.org/9071
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I982505476c6c47d7284dc1dc5b840283d9548ca2
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 1
Gerrit-Owner: William McCall <william.mccall at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 20:08:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180601/c01ede7e/attachment.html>