<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9071">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is a really good test.  It is a better test than I was expecting.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Just have some minor things to clean up.</p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9071/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9071/1//COMMIT_MSG@9">Patch Set #1, Line 9:</a> <code style="font-family:monospace,monospace">In ASTERISK-27877, the "Talking" header was added to ConfbridgeList.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Remove this sentence and add ASTERISK-27877 to its own line after this paragraph like normal commit messages.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9071/1//COMMIT_MSG@12">Patch Set #1, Line 12:</a> <code style="font-family:monospace,monospace">and 'ConfbridgeTalking' events to tell when to check the change in the 'Talking'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">...in the ConfbridgeList 'Talking'...</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/confbridge_talking_list/sipp/invite.xml">File tests/apps/confbridge/confbridge_talking_list/sipp/invite.xml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/confbridge_talking_list/sipp/invite.xml@77">Patch Set #1, Line 77:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to add</p><p style="white-space: pre-wrap; word-wrap: break-word;"><recv response="200" /></p><p style="white-space: pre-wrap; word-wrap: break-word;">to complete the BYE transaction.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/confbridge_talking_list/test-config.yaml">File tests/apps/confbridge/confbridge_talking_list/test-config.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/confbridge_talking_list/test-config.yaml@85">Patch Set #1, Line 85:</a> <code style="font-family:monospace,monospace">        - asterisk : 'chan_pjsip'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Add missing test dependency since it uses CALLERID() dialplan function:</p><ul><li>asterisk: 'func_callerid'</li></ul></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/tests.yaml">File tests/apps/confbridge/tests.yaml:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9071/1/tests/apps/confbridge/tests.yaml@20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace">    - test: 'confbridge_talking_list'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should add this in sorted order.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9071">change 9071</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9071"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I982505476c6c47d7284dc1dc5b840283d9548ca2 </div>
<div style="display:none"> Gerrit-Change-Number: 9071 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: William McCall <william.mccall@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 01 Jun 2018 20:08:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>