[Asterisk-code-review] thirdparty/pjproject: Fix deadlock in response retransmissions (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/9477 )

Change subject: thirdparty/pjproject: Fix deadlock in response retransmissions
......................................................................


Patch Set 4: Code-Review-2

We've talked about this and were hoping to catch you on IRC before you called it a day but we missed you.   We think a better alternative than either cloning tdata or adding the lock would be to just ignore duplicate 183 messages in chan_pjsip.c/chan_pjsip_indicate().  You may have to keep a state variable with the cseq of the 183s to know that a new one is a dup but it should be fairly easy to implement.


-- 
To view, visit https://gerrit.asterisk.org/9477
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic381004a3a212fe1d8eca0e707fe09dba4a6ab4e
Gerrit-Change-Number: 9477
Gerrit-PatchSet: 4
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Torrey Searle <tsearle at gmail.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 13:25:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180724/a51e32da/attachment.html>