[Asterisk-code-review] t38 fast reject: remove dependency on rtpdump (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/9379 )

Change subject: t38_fast_reject: remove dependency on rtpdump
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.asterisk.org/#/c/9379/2/tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.py
File tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.py:

https://gerrit.asterisk.org/#/c/9379/2/tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.py@23
PS2, Line 23: csvfile.close()
Could remove this if you wanted as it's not needed. Once the scope exits the 'with' statement the file is automatically closed. That being said there is no harm in calling close here.


https://gerrit.asterisk.org/#/c/9379/2/tests/fax/pjsip/t38_fast_reject/run-test
File tests/fax/pjsip/t38_fast_reject/run-test:

https://gerrit.asterisk.org/#/c/9379/2/tests/fax/pjsip/t38_fast_reject/run-test@71
PS2, Line 71:     ret_A = subprocess.call([WORKING_DIR + "/check_reinvite_rtt.py", WORKING_DIR+"/A_PARTY_STAT.log"])
Since check_reinvite_rtt is now python code I think you can call it directly as a function without using subprocess. But it does work as is.



-- 
To view, visit https://gerrit.asterisk.org/9379
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia73ef502f72bd75522d4b6656f6070807dbef349
Gerrit-Change-Number: 9379
Gerrit-PatchSet: 2
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 20 Jul 2018 17:24:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180720/336218e4/attachment.html>