<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.asterisk.org/9379">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9379/2/tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.py">File tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9379/2/tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.py@23">Patch Set #2, Line 23:</a> <code style="font-family:monospace,monospace">csvfile.close()</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Could remove this if you wanted as it's not needed. Once the scope exits the 'with' statement the file is automatically closed. That being said there is no harm in calling close here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9379/2/tests/fax/pjsip/t38_fast_reject/run-test">File tests/fax/pjsip/t38_fast_reject/run-test:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9379/2/tests/fax/pjsip/t38_fast_reject/run-test@71">Patch Set #2, Line 71:</a> <code style="font-family:monospace,monospace">    ret_A = subprocess.call([WORKING_DIR + "/check_reinvite_rtt.py", WORKING_DIR+"/A_PARTY_STAT.log"])</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Since check_reinvite_rtt is now python code I think you can call it directly as a function without using subprocess. But it does work as is.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9379">change 9379</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9379"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia73ef502f72bd75522d4b6656f6070807dbef349 </div>
<div style="display:none"> Gerrit-Change-Number: 9379 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 20 Jul 2018 17:24:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>