[Asterisk-code-review] testsuite: add tests to ensure ice in ANSWER only if offered (testsuite[master])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/9428 )

Change subject: testsuite: add tests to ensure ice in ANSWER only if offered
......................................................................


Patch Set 1: Code-Review-1

(8 comments)

This can be cherry picked to appropriate testsuite branches

https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/run-test
File tests/channels/pjsip/ice/ice_not_offered/run-test:

https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/run-test@3
PS1, Line 3: Copyright (C) 2010, Digium, Inc.
           : Russell Bryant <russell at digium.com>
Update copyright and author


https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/sipp/B_PARTY.xml
File tests/channels/pjsip/ice/ice_not_offered/sipp/B_PARTY.xml:

https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/sipp/B_PARTY.xml@67
PS1, Line 67: <recv request="BYE"> 
            : </recv> 
            :  
            : <send> 
            : <![CDATA[ 
            :   
            : SIP/2.0 200 OK 
            : [last_Via:] 
            : [last_From:] 
            : [last_To:] 
            : [last_Call-ID:] 
            : [last_CSeq:] 
            : Content-Length: 0 
            :  
            : ]]> 
            : </send> 
red space


https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/test-config.yaml
File tests/channels/pjsip/ice/ice_not_offered/test-config.yaml:

https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/test-config.yaml@4
PS1, Line 4:          'Endpôint A has ice enabled and sends an invite w/o ICE candidates in the SDP.  The 
red space


https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/test-config.yaml@8
PS1, Line 8:     minversion: '1.4'
Can remove


https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/run-test
File tests/channels/pjsip/ice/ice_offered/run-test:

https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/run-test@3
PS1, Line 3: Copyright (C) 2010, Digium, Inc.
           : Russell Bryant <russell at digium.com>
Update copyright and author


https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/sipp/B_PARTY.xml
File tests/channels/pjsip/ice/ice_offered/sipp/B_PARTY.xml:

https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/sipp/B_PARTY.xml@67
PS1, Line 67: <recv request="BYE"> 
            : </recv> 
            :  
            : <send> 
            : <![CDATA[ 
            :   
            : SIP/2.0 200 OK 
            : [last_Via:] 
            : [last_From:] 
            : [last_To:] 
            : [last_Call-ID:] 
            : [last_CSeq:] 
            : Content-Length: 0 
            :  
            : ]]> 
            : </send> 
red space


https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/test-config.yaml
File tests/channels/pjsip/ice/ice_offered/test-config.yaml:

https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/test-config.yaml@4
PS1, Line 4:          'Endpôint A has ice enabled and sends an invite with ICE candidates in the SDP.  The 
red space


https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/test-config.yaml@8
PS1, Line 8:     minversion: '13'
We don't use versioning in the testsuite anymore now that we have branches, so this line isn't necessary.



-- 
To view, visit https://gerrit.asterisk.org/9428
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4744c062e17862bf60eaa76f46af2ba2743e650
Gerrit-Change-Number: 9428
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Fri, 13 Jul 2018 21:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180713/8edd3209/attachment-0001.html>