<p style="white-space: pre-wrap; word-wrap: break-word;">This can be cherry picked to appropriate testsuite branches</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/9428">View Change</a></p><p>8 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/run-test">File tests/channels/pjsip/ice/ice_not_offered/run-test:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/run-test@3">Patch Set #1, Line 3:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Copyright (C) 2010, Digium, Inc.<br>Russell Bryant <russell@digium.com><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Update copyright and author</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/sipp/B_PARTY.xml">File tests/channels/pjsip/ice/ice_not_offered/sipp/B_PARTY.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/sipp/B_PARTY.xml@67">Patch Set #1, Line 67:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><recv request="BYE"> <br></recv> <br> <br><send> <br><![CDATA[ <br> <br>SIP/2.0 200 OK <br>[last_Via:] <br>[last_From:] <br>[last_To:] <br>[last_Call-ID:] <br>[last_CSeq:] <br>Content-Length: 0 <br> <br>]]> <br></send> <br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">red space</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/test-config.yaml">File tests/channels/pjsip/ice/ice_not_offered/test-config.yaml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/test-config.yaml@4">Patch Set #1, Line 4:</a> <code style="font-family:monospace,monospace"> 'Endpôint A has ice enabled and sends an invite w/o ICE candidates in the SDP. The </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red space</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_not_offered/test-config.yaml@8">Patch Set #1, Line 8:</a> <code style="font-family:monospace,monospace"> minversion: '1.4'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can remove</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/run-test">File tests/channels/pjsip/ice/ice_offered/run-test:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/run-test@3">Patch Set #1, Line 3:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Copyright (C) 2010, Digium, Inc.<br>Russell Bryant <russell@digium.com><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Update copyright and author</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/sipp/B_PARTY.xml">File tests/channels/pjsip/ice/ice_offered/sipp/B_PARTY.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/sipp/B_PARTY.xml@67">Patch Set #1, Line 67:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><recv request="BYE"> <br></recv> <br> <br><send> <br><![CDATA[ <br> <br>SIP/2.0 200 OK <br>[last_Via:] <br>[last_From:] <br>[last_To:] <br>[last_Call-ID:] <br>[last_CSeq:] <br>Content-Length: 0 <br> <br>]]> <br></send> <br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">red space</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/test-config.yaml">File tests/channels/pjsip/ice/ice_offered/test-config.yaml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/test-config.yaml@4">Patch Set #1, Line 4:</a> <code style="font-family:monospace,monospace"> 'Endpôint A has ice enabled and sends an invite with ICE candidates in the SDP. The </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">red space</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9428/1/tests/channels/pjsip/ice/ice_offered/test-config.yaml@8">Patch Set #1, Line 8:</a> <code style="font-family:monospace,monospace"> minversion: '13'</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">We don't use versioning in the testsuite anymore now that we have branches, so this line isn't necessary.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9428">change 9428</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9428"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic4744c062e17862bf60eaa76f46af2ba2743e650 </div>
<div style="display:none"> Gerrit-Change-Number: 9428 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 13 Jul 2018 21:10:10 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>