[Asterisk-code-review] fax/pjsip/gateway t38 g711: Misc cleanups (testsuite[13])

[Jenkins2]

Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/9337 )

Change subject: fax/pjsip/gateway_t38_g711: Misc cleanups
......................................................................

fax/pjsip/gateway_t38_g711: Misc cleanups

* Enable pjsip debug
* Remove unnecessary context set.
* Update test dependencies
* Update test description

Change-Id: I68e670315bec98fd24f2aed10065b9b146cb8f2c
---
M tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf
M tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf
M tests/fax/pjsip/gateway_t38_g711/test-config.yaml
3 files changed, 15 insertions(+), 6 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf b/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf
index 6b86cb9..c2ce7f7 100644
--- a/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf
+++ b/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf
@@ -1,3 +1,7 @@
+[global]
+type=global
+debug=yes
+
 [local-transport]
 type=transport
 protocol=udp
@@ -5,7 +9,6 @@
 
 [endpoint-template](!)
 type=endpoint
-context=default
 allow=!all,ulaw,alaw
 context=receivefax
 media_address=127.0.0.1
@@ -16,4 +19,4 @@
 
 [ast2-g711](endpoint-template)
 t38_udptl=no
-from_user=ast1-g711
\ No newline at end of file
+from_user=ast1-g711
diff --git a/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf b/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf
index 2edd549..2a00ebf 100644
--- a/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf
+++ b/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf
@@ -1,3 +1,7 @@
+[global]
+type=global
+debug=yes
+
 [local-transport]
 type=transport
 protocol=udp
@@ -5,7 +9,6 @@
 
 [endpoint-template](!)
 type=endpoint
-context=default
 allow=!all,ulaw,alaw
 context=gatewayfax
 media_address=127.0.0.2
@@ -16,4 +19,4 @@
 
 [ast1-g711](endpoint-template)
 t38_udptl=no
-from_user=ast2-g711
\ No newline at end of file
+from_user=ast2-g711
diff --git a/tests/fax/pjsip/gateway_t38_g711/test-config.yaml b/tests/fax/pjsip/gateway_t38_g711/test-config.yaml
index 8794dab..ddbbc9e 100644
--- a/tests/fax/pjsip/gateway_t38_g711/test-config.yaml
+++ b/tests/fax/pjsip/gateway_t38_g711/test-config.yaml
@@ -4,8 +4,8 @@
         This test verifies proper gateway functionality when the sending side
         is t38 and the receiving side is g711. Two asterisk instances are
         started and a call is made from ast1 to ast2. Ast2 will start a fax
-        gateway and send the call back to ast1. Ast2 runs SendFax() on the
-        sending side and ReceiveFax() on the receiving side. If the fax is
+        gateway and send the call back to ast1. Ast1 runs SendFax() on the
+        calling side and ReceiveFax() on the answering side. If the fax is
         successful, the test passes.
 
         The call flow looks like this:
@@ -22,7 +22,10 @@
         - python : 'twisted'
         - python : 'starpy'
         - custom : 'fax'
+        - asterisk : 'app_dial'
+        - asterisk : 'app_userevent'
         - asterisk : 'chan_pjsip'
+        - asterisk : 'res_fax'
         - asterisk : 'res_pjsip_t38'
     tags:
         - pjsip

-- 
To view, visit https://gerrit.asterisk.org/9337
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: I68e670315bec98fd24f2aed10065b9b146cb8f2c
Gerrit-Change-Number: 9337
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180710/cc01ada7/attachment.html>