<p>Jenkins2 <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/9337">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Jenkins2: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fax/pjsip/gateway_t38_g711: Misc cleanups<br><br>* Enable pjsip debug<br>* Remove unnecessary context set.<br>* Update test dependencies<br>* Update test description<br><br>Change-Id: I68e670315bec98fd24f2aed10065b9b146cb8f2c<br>---<br>M tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf<br>M tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf<br>M tests/fax/pjsip/gateway_t38_g711/test-config.yaml<br>3 files changed, 15 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf b/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf</span><br><span>index 6b86cb9..c2ce7f7 100644</span><br><span>--- a/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf</span><br><span>+++ b/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf</span><br><span>@@ -1,3 +1,7 @@</span><br><span style="color: hsl(120, 100%, 40%);">+[global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span style="color: hsl(120, 100%, 40%);">+debug=yes</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> [local-transport]</span><br><span> type=transport</span><br><span> protocol=udp</span><br><span>@@ -5,7 +9,6 @@</span><br><span> </span><br><span> [endpoint-template](!)</span><br><span> type=endpoint</span><br><span style="color: hsl(0, 100%, 40%);">-context=default</span><br><span> allow=!all,ulaw,alaw</span><br><span> context=receivefax</span><br><span> media_address=127.0.0.1</span><br><span>@@ -16,4 +19,4 @@</span><br><span> </span><br><span> [ast2-g711](endpoint-template)</span><br><span> t38_udptl=no</span><br><span style="color: hsl(0, 100%, 40%);">-from_user=ast1-g711</span><br><span>\ No newline at end of file</span><br><span style="color: hsl(120, 100%, 40%);">+from_user=ast1-g711</span><br><span>diff --git a/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf b/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf</span><br><span>index 2edd549..2a00ebf 100644</span><br><span>--- a/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf</span><br><span>+++ b/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf</span><br><span>@@ -1,3 +1,7 @@</span><br><span style="color: hsl(120, 100%, 40%);">+[global]</span><br><span style="color: hsl(120, 100%, 40%);">+type=global</span><br><span style="color: hsl(120, 100%, 40%);">+debug=yes</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> [local-transport]</span><br><span> type=transport</span><br><span> protocol=udp</span><br><span>@@ -5,7 +9,6 @@</span><br><span> </span><br><span> [endpoint-template](!)</span><br><span> type=endpoint</span><br><span style="color: hsl(0, 100%, 40%);">-context=default</span><br><span> allow=!all,ulaw,alaw</span><br><span> context=gatewayfax</span><br><span> media_address=127.0.0.2</span><br><span>@@ -16,4 +19,4 @@</span><br><span> </span><br><span> [ast1-g711](endpoint-template)</span><br><span> t38_udptl=no</span><br><span style="color: hsl(0, 100%, 40%);">-from_user=ast2-g711</span><br><span>\ No newline at end of file</span><br><span style="color: hsl(120, 100%, 40%);">+from_user=ast2-g711</span><br><span>diff --git a/tests/fax/pjsip/gateway_t38_g711/test-config.yaml b/tests/fax/pjsip/gateway_t38_g711/test-config.yaml</span><br><span>index 8794dab..ddbbc9e 100644</span><br><span>--- a/tests/fax/pjsip/gateway_t38_g711/test-config.yaml</span><br><span>+++ b/tests/fax/pjsip/gateway_t38_g711/test-config.yaml</span><br><span>@@ -4,8 +4,8 @@</span><br><span>         This test verifies proper gateway functionality when the sending side</span><br><span>         is t38 and the receiving side is g711. Two asterisk instances are</span><br><span>         started and a call is made from ast1 to ast2. Ast2 will start a fax</span><br><span style="color: hsl(0, 100%, 40%);">-        gateway and send the call back to ast1. Ast2 runs SendFax() on the</span><br><span style="color: hsl(0, 100%, 40%);">-        sending side and ReceiveFax() on the receiving side. If the fax is</span><br><span style="color: hsl(120, 100%, 40%);">+        gateway and send the call back to ast1. Ast1 runs SendFax() on the</span><br><span style="color: hsl(120, 100%, 40%);">+        calling side and ReceiveFax() on the answering side. If the fax is</span><br><span>         successful, the test passes.</span><br><span> </span><br><span>         The call flow looks like this:</span><br><span>@@ -22,7 +22,10 @@</span><br><span>         - python : 'twisted'</span><br><span>         - python : 'starpy'</span><br><span>         - custom : 'fax'</span><br><span style="color: hsl(120, 100%, 40%);">+        - asterisk : 'app_dial'</span><br><span style="color: hsl(120, 100%, 40%);">+        - asterisk : 'app_userevent'</span><br><span>         - asterisk : 'chan_pjsip'</span><br><span style="color: hsl(120, 100%, 40%);">+        - asterisk : 'res_fax'</span><br><span>         - asterisk : 'res_pjsip_t38'</span><br><span>     tags:</span><br><span>         - pjsip</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/9337">change 9337</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9337"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I68e670315bec98fd24f2aed10065b9b146cb8f2c </div>
<div style="display:none"> Gerrit-Change-Number: 9337 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>