[Asterisk-code-review] res parking: Add dialplan functions for lot state and channel (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/9375 )

Change subject: res_parking: Add dialplan functions for lot state and channel
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/9375/1/res/parking/parking_bridge_features.c
File res/parking/parking_bridge_features.c:

https://gerrit.asterisk.org/#/c/9375/1/res/parking/parking_bridge_features.c@47
PS1, Line 47:         <function name="CHECK_PARKING_SLOT" language="en_US">
> I lean toward renaming this function to "IS_PARKING_SLOT_OCCUPIED".
Actually scratch that (kinda long). I'd suggest renaming to "PARK_OCCUPIED" as this will sort it better in documentations like "core show functions".


https://gerrit.asterisk.org/#/c/9375/1/res/parking/parking_bridge_features.c@62
PS1, Line 62:         <function name="GET_PARKING_SLOT_CHANNEL" language="en_US">
I suggest renaming this to "PARK_GET_CHANNEL" for similar reasons already mentioned (helps with sorting).



-- 
To view, visit https://gerrit.asterisk.org/9375
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idba6ae55b8a53f734238cb3d995cedb95c0e7b74
Gerrit-Change-Number: 9375
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Elson <joshelson at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 23:22:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180706/f467a4e1/attachment.html>