<p><a href="https://gerrit.asterisk.org/9375">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/9375/1/res/parking/parking_bridge_features.c">File res/parking/parking_bridge_features.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9375/1/res/parking/parking_bridge_features.c@47">Patch Set #1, Line 47:</a> <code style="font-family:monospace,monospace">        <function name="CHECK_PARKING_SLOT" language="en_US"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I lean toward renaming this function to "IS_PARKING_SLOT_OCCUPIED".</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Actually scratch that (kinda long). I'd suggest renaming to "PARK_OCCUPIED" as this will sort it better in documentations like "core show functions".</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9375/1/res/parking/parking_bridge_features.c@62">Patch Set #1, Line 62:</a> <code style="font-family:monospace,monospace">        <function name="GET_PARKING_SLOT_CHANNEL" language="en_US"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I suggest renaming this to "PARK_GET_CHANNEL" for similar reasons already mentioned (helps with sorting).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9375">change 9375</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9375"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Idba6ae55b8a53f734238cb3d995cedb95c0e7b74 </div>
<div style="display:none"> Gerrit-Change-Number: 9375 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Elson <joshelson@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 06 Jul 2018 23:22:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>