[Asterisk-code-review] backtrace: Avoid -Wlogical-not-parentheses. (asterisk[13])

Alexander Traud asteriskteam at digium.com
Wed Jan 31 02:39:03 CST 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8105 )

Change subject: backtrace: Avoid -Wlogical-not-parentheses.
......................................................................


Patch Set 1:

OK. I am a bit confused about your ‘more’. According to clang (and my book about precedence) your proposal changes the code. clang offers both alternatives as suggestion. So, this was a bug actually?


-- 
To view, visit https://gerrit.asterisk.org/8105
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ec3e144d425a976c02811bd23cd0c533d2eca4e
Gerrit-Change-Number: 8105
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 31 Jan 2018 08:39:03 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180131/bed02e00/attachment.html>


More information about the asterisk-code-review mailing list