[Asterisk-code-review] backtrace: Avoid -Wlogical-not-parentheses. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Tue Jan 30 10:41:59 CST 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8105 )

Change subject: backtrace: Avoid -Wlogical-not-parentheses.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/8105/1/main/backtrace.c
File main/backtrace.c:

https://gerrit.asterisk.org/#/c/8105/1/main/backtrace.c@134
PS1, Line 134: 				if ((!bfd_get_section_flags(bfdobj, section)) & SEC_ALLOC ||
To fix the error, it makes more sense for the line to be:

if (!(bfd_get_section_flags(bfdobj, section) & SEC_ALLOC) ||



-- 
To view, visit https://gerrit.asterisk.org/8105
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ec3e144d425a976c02811bd23cd0c533d2eca4e
Gerrit-Change-Number: 8105
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 30 Jan 2018 16:41:59 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180130/1a2195f2/attachment.html>


More information about the asterisk-code-review mailing list