[Asterisk-code-review] res pjsip pubsub: Prune subs with reliable transports at sta... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8082 )

Change subject: res_pjsip_pubsub: Prune subs with reliable transports at startup
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip/include/res_pjsip_private.h
File res/res_pjsip/include/res_pjsip_private.h:

https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip/include/res_pjsip_private.h@433
PS3, Line 433: int ast_sip_will_uri_survive_restart(pjsip_sip_uri *uri, struct ast_sip_endpoint, endpoint,
Compiler: endpoint has no type.


https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip/pjsip_transport_events.c
File res/res_pjsip/pjsip_transport_events.c:

https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip/pjsip_transport_events.c@219
PS3, Line 219: 			AST_VECTOR_REMOVE_UNORDERED(&monitored->monitors, idx++);
Passing parameters with side effects to macros is usually bad.  Should really increment idx after the macro in its own statement for safety.


https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip_pubsub.c@645
PS3, Line 645: 							sub_tree->endpoint, rdata);
Probably should be passing:
sub_tree->persistence->endpoint.



-- 
To view, visit https://gerrit.asterisk.org/8082
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee87cf4eb9b7b2b93d5739a72af52d6ca8fbbe36
Gerrit-Change-Number: 8082
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 29 Jan 2018 23:13:26 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180129/b675a124/attachment.html>