<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8082">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip/include/res_pjsip_private.h">File res/res_pjsip/include/res_pjsip_private.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip/include/res_pjsip_private.h@433">Patch Set #3, Line 433:</a> <code style="font-family:monospace,monospace">int ast_sip_will_uri_survive_restart(pjsip_sip_uri *uri, struct ast_sip_endpoint, endpoint,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Compiler: endpoint has no type.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip/pjsip_transport_events.c">File res/res_pjsip/pjsip_transport_events.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip/pjsip_transport_events.c@219">Patch Set #3, Line 219:</a> <code style="font-family:monospace,monospace">                 AST_VECTOR_REMOVE_UNORDERED(&monitored->monitors, idx++);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Passing parameters with side effects to macros is usually bad.  Should really increment idx after the macro in its own statement for safety.</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip_pubsub.c">File res/res_pjsip_pubsub.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8082/3/res/res_pjsip_pubsub.c@645">Patch Set #3, Line 645:</a> <code style="font-family:monospace,monospace">                                                       sub_tree->endpoint, rdata);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably should be passing:<br>sub_tree->persistence->endpoint.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8082">change 8082</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8082"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iee87cf4eb9b7b2b93d5739a72af52d6ca8fbbe36 </div>
<div style="display:none"> Gerrit-Change-Number: 8082 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 29 Jan 2018 23:13:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>