[Asterisk-code-review] Update chkcore and chkextra for existing languages. (repotools[master])

[George Joseph]

George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/8058 )

Change subject: Update chkcore and chkextra for existing languages.
......................................................................

Update chkcore and chkextra for existing languages.

Change-Id: Iaf59c4bec99ea8c53bfac9bd02cca1a9b322bcfa
---
M sound_tools/scripts/chkcore
M sound_tools/scripts/chkextra
2 files changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Verified
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/sound_tools/scripts/chkcore b/sound_tools/scripts/chkcore
index ee47db9..ecccde2 100755
--- a/sound_tools/scripts/chkcore
+++ b/sound_tools/scripts/chkcore
@@ -1,6 +1,11 @@
 #!/bin/bash
 
-for lang in en es fr en_AU ru; do
+# There are several problems with this script.
+# 1) This only checks the first level directory.  It does not check subdirectories.
+# 2) This can be fooled by files that are prefixes of other files.
+# 3) This does not check if there are entries in the .txt file with no .wav file.
+
+for lang in en en_AU en_GB en_NZ es fr it ja ru sv; do
 	found=0
 	for wav in ../core/$lang/*.wav ; do
 		base=`basename $wav`
diff --git a/sound_tools/scripts/chkextra b/sound_tools/scripts/chkextra
index ca07a5c..8c831ed 100755
--- a/sound_tools/scripts/chkextra
+++ b/sound_tools/scripts/chkextra
@@ -1,6 +1,11 @@
 #!/bin/bash
 
-for lang in en fr; do
+# There are several problems with this script.
+# 1) This only checks the first level directory.  It does not check subdirectories.
+# 2) This can be fooled by files that are prefixes of other files.
+# 3) This does not check if there are entries in the .txt file with no .wav file.
+
+for lang in en en_GB fr; do
 	found=0
 	for wav in ../extra/$lang/*.wav ; do
 		base=`basename $wav`

-- 
To view, visit https://gerrit.asterisk.org/8058
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf59c4bec99ea8c53bfac9bd02cca1a9b322bcfa
Gerrit-Change-Number: 8058
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180129/7bd52d5d/attachment.html>