<p>George Joseph <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/8058">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Joshua Colp: Looks good to me, but someone else must approve; Verified
George Joseph: Looks good to me, approved; Approved for Submit
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Update chkcore and chkextra for existing languages.<br><br>Change-Id: Iaf59c4bec99ea8c53bfac9bd02cca1a9b322bcfa<br>---<br>M sound_tools/scripts/chkcore<br>M sound_tools/scripts/chkextra<br>2 files changed, 12 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/sound_tools/scripts/chkcore b/sound_tools/scripts/chkcore<br>index ee47db9..ecccde2 100755<br>--- a/sound_tools/scripts/chkcore<br>+++ b/sound_tools/scripts/chkcore<br>@@ -1,6 +1,11 @@<br> #!/bin/bash<br> <br>-for lang in en es fr en_AU ru; do<br>+# There are several problems with this script.<br>+# 1) This only checks the first level directory. It does not check subdirectories.<br>+# 2) This can be fooled by files that are prefixes of other files.<br>+# 3) This does not check if there are entries in the .txt file with no .wav file.<br>+<br>+for lang in en en_AU en_GB en_NZ es fr it ja ru sv; do<br> found=0<br> for wav in ../core/$lang/*.wav ; do<br> base=`basename $wav`<br>diff --git a/sound_tools/scripts/chkextra b/sound_tools/scripts/chkextra<br>index ca07a5c..8c831ed 100755<br>--- a/sound_tools/scripts/chkextra<br>+++ b/sound_tools/scripts/chkextra<br>@@ -1,6 +1,11 @@<br> #!/bin/bash<br> <br>-for lang in en fr; do<br>+# There are several problems with this script.<br>+# 1) This only checks the first level directory. It does not check subdirectories.<br>+# 2) This can be fooled by files that are prefixes of other files.<br>+# 3) This does not check if there are entries in the .txt file with no .wav file.<br>+<br>+for lang in en en_GB fr; do<br> found=0<br> for wav in ../extra/$lang/*.wav ; do<br> base=`basename $wav`<br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/8058">change 8058</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8058"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: repotools </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iaf59c4bec99ea8c53bfac9bd02cca1a9b322bcfa </div>
<div style="display:none"> Gerrit-Change-Number: 8058 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>